Repository navigation
Publish accepted work and file scrubbed problem notes after duplicate searches - #397
Conversation
# Conflicts: # oxa/oxa-work/src/lib.rs
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (4)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 232eb0efc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
First-pass review by oxa → oxc → Codex findings
Additional defects
TIER: T3 🤖 Generated with Claude Code (oxa review lane) |
|
First-pass REVISE addressed at 8bf1f38: both execution and external-write entry points preserve the saved offline restriction (two failing-first cases). Optional publication/report fields default to inactive values while required core state remains strict. Draft-creation errors now become retryable failed-report records and finish the reporting checkpoint; another failing-first case proves plain invocation and --report-problems retry do not replay the agent. All four new regressions and all 208 touched-crate tests pass, plus fmt/clippy/four scans. The publication-retry point is intentionally opt-in: --publish retries its saved checkpoint without --rerun, as the existing queue/refusal/retry regression demonstrates. A plain task-file invocation does not authorize network writes. --rerun is needed only to re-check branch drift. Continuing queue mode without waiting for re-review. |
|
First-pass review by oxa → oxc → Codex findings
New findings
TIER: T3 🤖 Generated with Claude Code (oxa review lane) |
# Conflicts: # oxa/oxa-work/src/lib.rs
There was a problem hiding this comment.
🛡️ Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: 23eaa743ba
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
| command.args(args).current_dir(cwd); | ||
| oxa_work::command_runner_with_stdin(command, Some(1_048_576), Stdio::from(lock.try_clone().ok()?)) |
There was a problem hiding this comment.
🛡️ Codex Security Review
Security: Bind problem reports to an explicit GitHub host
When --report-problems runs with ambient GH_HOST—for example in a GHES shell—this new runner inherits it while every --repo value and confirmation contains only OWNER/NAME. gh therefore sends approved search terms and later issue/comment bodies to GH_HOST, not necessarily the configured public repository. An authenticated unintended host can receive project symptom terms and owner-authorized writes under a misleading destination. Remove ambient host selectors and pass/display a host-qualified repository. The report scrubber is pattern-based, so confirmation is the residual privacy boundary.
SECURITY.md reference: oxa/SECURITY.md:L33-L35
Useful? React with 👍 / 👎.
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🛡️ Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: 2c1b106d8b
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
| .env_remove("GH_REPO") | ||
| .env_remove("GH_HOST") |
There was a problem hiding this comment.
🛡️ Codex Security Review
Security: Bind inherited GitHub tokens to the origin host
When GH_ENTERPRISE_TOKEN is set for a legitimate GHES session and origin names an attacker-controlled different host, clear or host-bind the token before this helper runs. It removes GH_HOST but inherits the generic enterprise token; the later gh repo view <origin> occurs before confirmation, and gh attaches that token to the explicit host. Thus requesting --publish in a trusted malicious clone can disclose the user's GitHub token before the prompt identifies the destination. Fresh evidence beyond the prior repository-target issue is the final helper's mismatched host/token handling.
SECURITY.md reference: SECURITY.md:L9-L10
Useful? React with 👍 / 👎.
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Feature A (native work board) and the work-reporting path for Feature I. Owner acceptance #1214
T3 — opt-in work publication and scrubbed problem reporting (#333). Ready at the current main refresh.
oxa work ... --publishpushes the accepted saved commit only after controlling-terminal approval. Both publication and problem-reporting flags default off and reject agent-originated invocation; offline publication refuses. Notes pass through the trusted frontend scrubber before checkpoint/emission. Publication retains the origin host, checks queue membership after confirmation, and updates only its managed acceptance section while preserving owner-written PR text.Terminal action recovery preserves the accepted head on an ordinary invocation. Explicit rerun of Publishing/Reporting freezes fresh execution/check inputs and runs validation again. Unfinished worker/save deadlines, saved offline restrictions, report serialization and actual save retry semantics are retained.
Removes: superseded inherited host-shell runner, flat Git-local checkpoints and old CLI adapters, replaced by main's trusted supervisor/checkpoint APIs. Payload-bearing note persistence, unchecked-head resealing and stale PR metadata are removed; owner text and existing protections remain. No new scanner or project-hook execution is introduced. The credential-scanner claim assumes approved publication of project-readable content, which the published SECURITY.md threat-model exclusions and issue333 do not promise to prevent; source-backed adjudication is397comment6958079581. No masked-credential or approval bypass was established by that claim.
Validation: both publication-recovery regressions failed in44146808409 and passed in44148608394 on both architectures at95c55cba. Prior privacy/origin/body, real-worker save retry, red/no-push, real-TTY, offline and queue controls remain. Current head cb7ae1f normally merges main a86ba95, preserving native helper_queue alongside publication; draft checks44155708702 passed and lane44155693005 is running. No local builds/tests or real providers/keys; hosted fixtures use synthetic data and isolated HOME. Current required CI, Cloud qualification and the narrow execution/auth boundary read remain gates. Auto-approver owns review requests; no repeated builder request or merge clearance is implied.
Main refresh
dcd4f463a26a5bcb2627cc3c6cb5d616d9a4d5f6merges main78d1dda2. The two conflict resolutions retain main's protected work-storage check, committed verification and mirror declarations, plus this PR's publication and report routes. The publication/report modules and dedicated tests are byte-identical tocb7ae1fd. The shared dispatch has formatting changes from composing both routes.Ports the post-commit push hook and dogfood reporting rows of #307 at the opt-in work publication and report boundary. Hosted lane 44174046845 and draft checks 44174060604 record qualification for this head. The required draft gate passed and the PR is ready for full required checks.
Publication recovery and committed acceptance
Repair head
8ac1cc9754adefef06bc0094c12f6fd55f153222preserves pending saves when publication is requested early. A resumed save must pass acceptance on its recovered commit before receiving a successful result. Publication runs frozen acceptance against the clean committed export before contacting GitHub, then checks that proof again before pushing. Problem reports share the bounded command runner and keep the task lock in the child.Removes: the duplicate report subprocess runner and the use of prior success as proof for a recovered save or publication.
The test-first lane failed on the publication regressions. The fixed x86_64 and ARM64 lane passed for oxa-work and its affected consumers, including oxa-cli. The draft required gate passed and this head was marked ready. Full ready checks 44180507432 passed.
Main refresh after #1162
Earlier refreshed head
23eaa743ba5626534ac223ffcd2e717ee13c0526includes mainedae4644. The two normal merges adopt the shared bounded command runner that main moved into oxa-work and retain both the existing refill and report routes. The report command still carries the task lock into the child. Publication and clean committed acceptance use the same code and tests qualified above.Current required checks · Current hosted lane
Protected checkpoint refresh
Head
adde48e3f774a96014b451592978a7c7fbb9eeb5merges mainf02fc17b. Action recovery uses main's checked checkpoint loader. Publication and report retries also validate the protected storage and task lock before loading their checkpoint. The Work2 refill and shared lead HTTP modules remain available.Exact required checks · Exact hosted lane
The refreshed head passed the affected oxa-work and oxa-cli hosted lane on x86_64 and ARM64 and the full required ready checks. Codex code and security reviews reported no findings at this exact head.
Code review receipt · Security review receipt
Shared report deadline refresh
Head
2c1b106d8bad6587fbcb0b0f80410d0eb3827ademerges main66e9591f. The report subprocess uses the landed shared runner, with its existing output limit and task lock on stdin. Required checks · Hosted laneThe exact shared-deadline head passed its required workflow and both hosted architecture lanes. Codex review at this head reported no major issues. The Rust CodeQL analysis was still running at verification.
Publication destination and subprocess guards
Head
373b8bdfb9f149fc798c46ec02e29b984f19d1deruns GitHub publication and Git push through the shared bounded runner with the task lock. The approved origin uses the CLI's saved login for that host. Existing PR updates require a same-repository head. Problem reports display and use the same qualified GitHub.com repository.The test-first lane reproduced oversized metadata acceptance, ambient enterprise credential forwarding and same-owner fork acceptance. The repair is under hosted oxa-work/oxa-cli qualification and CodeQL.
Qualification after #1090 landed
The normal conflict resolution preserves the #1090 PR packet route alongside the publication flags. Publication code, report code and their dedicated tests match the previously qualified repair. The refreshed head passed the required workflow and the hosted oxa-work/oxa-cli lane on x86_64 and ARM64.
Head
41c4b8986ea2e8e2cfc3092a3fcb0b4a58ad62a1.Conflict refresh after #1043 and #1099
Head
cb8174daef75d94fc8f8aa0bc0f964a4687b381c. The normal merge retains #1043 batch base normalization and #1099 supervisor isolation alongside publication and action recovery. The publication and report modules match the previously qualified versions.Hosted lane · Required checks